Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix validate victims check for preempt action #572

Merged
merged 1 commit into from
Nov 28, 2019
Merged

fix validate victims check for preempt action #572

merged 1 commit into from
Nov 28, 2019

Conversation

zionwu
Copy link
Contributor

@zionwu zionwu commented Nov 28, 2019

Fix issue for preempt action that is similar with #565

@volcano-sh-bot volcano-sh-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 28, 2019
@k82cn
Copy link
Member

k82cn commented Nov 28, 2019

/lgtm
/approve

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 28, 2019
@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: k82cn, zionwu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 28, 2019
@TravisBuddy
Copy link

Hey @zionwu,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: d2b3ec60-1189-11ea-b8ff-d5ab8a371226

@volcano-sh-bot volcano-sh-bot merged commit 9077081 into volcano-sh:master Nov 28, 2019
@k82cn k82cn mentioned this pull request Dec 19, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hex108 hex108 Awaiting requested review from hex108

@k82cn k82cn Awaiting requested review from k82cn

Assignees

@k82cn k82cn

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zionwu @k82cn @volcano-sh-bot @TravisBuddy